On Tue, Jan 6, 2015 at 12:43 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2014-12-29 at 11:59 +0200, Arik Nemtsov wrote:
>> The function adding the supported channels IE during a TDLS connection had
>> several issues:
>> 1. If the entire subband is usable, the function exitted the loop without
>> adding it
>> 2. The function only checked chandef_usable, ignoring flags like RADAR
>> which would prevent TDLS off-channel communcation.
>> 3. HT20 was explicitly required in the chandef, while not a requirement
>> for TDLS off-channel.
>
>
> That's a strangely formatted commit message ... :)
I thought it's clearer this way. You disagree?
>
>
>> + if (cfg80211_reg_can_beacon(sdata->local->hw.wiphy,
>> + &chandef,
>> + sdata->wdev.iftype)) {
>> ch_cnt++;
>> continue;
>
> With some thinking, I can understand it - but that means you need a
> comment here.
Sure.
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
