> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Tuesday, January 06, 2015 12:59 > To: Peer, Ilan > Cc: linux-wireless@xxxxxxxxxxxxxxx; mcgrof@xxxxxxxx > Subject: Re: [PATCH v2 2/2] cfg80211: Schedule timeout for all CRDA calls > > On Mon, 2015-01-05 at 23:52 -0500, Ilan Peer wrote: > > Timeout was scheduled only in case CRDA was called due to user hints, > > but was not scheduled for other cases. This can result in regulatory > > hint processing getting stuck in case that there is no CRDA configured. > > I can understand this part. > > > Change this by scheduling a timeout every time CRDA is called. In > > addition, in restore_regulatory_settings() all pending requests are > > restored (and not only the user ones). > > Care to explain why, and why this should be in the same patch? Previously only the pending user hints were restored (not sure why, but maybe there was an assumption that the timeout was only scheduled for user hints?). Was not sure why all other hint types were not restored. I can move this to another patch it this is still reasonable. Ilan. ��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
