________________________________________
From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx]
Sent: Monday, January 05, 2015 2:51 PM
To: Avinash Patil
Cc: linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo; janusz.dziedzic@xxxxxxxxx
Subject: Re: [PATCH] cfg80211: check for carrier state only when offchanel CAC supported
On Wed, 2014-12-24 at 04:47 -0800, Avinash Patil wrote:
> + * @NL80211_EXT_FEATURE_OFFCHAN_CAC: This device/driver supports
> + * offchannel Channel Availibility Check(CAC).
>as Arend said, please indent (with a tab)
>You're also mis-spelling "availability" :)
> * @NUM_NL80211_EXT_FEATURES: number of extended features.
> * @MAX_NL80211_EXT_FEATURES: highest extended feature index.
> */
> enum nl80211_ext_feature_index {
>
> + NL80211_EXT_FEATURE_OFFCHAN_CAC,
>Better add it before rather than after the blank line.
>johannes
Thanks for review, Johannes.
Will send v3 with your comments addressed.
Thanks,
Avinash.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
