On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote: > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki <zajec5@xxxxxxxxx>: >> >> On 2 January 2015 at 18:46, Rickard Strandqvist >> <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote: >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek <sedat.dilek@xxxxxxxxx>: >> >> >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >> >> > On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist >> >> >> <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote: >> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used >> >> >>> anywhere. >> >> >>> >> >> >>> This was partially found by using a static code analysis program >> >> >>> called cppcheck. >> >> >> >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> >> >> is not handled by b43legacy. Should be safe to drop this code (we >> >> >> won't likely need it). >> >> >> >> >> >> Ack >> >> > >> >> > For future, we prefix patches with just a driver name. So this could >> >> > be simply called >> >> > b43legacy: radio.c: Remove unused function >> >> > >> >> >> >> Alternatively... >> >> >> >> "b43legacy: Remove unused function in radio.c" >> >> >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck >> >> to get such stuff? >> >> >> >> - Sedat - >> >> >> >> [1] https://lkml.org/lkml/2015/1/2/51 >> > >> > >> > >> > Hi Rafal and Sedat >> > >> > Rafal do you mean I should remove the entire b43legacy part? >> >> 1) I gave you Ack for the changes >> 2) You could drop "net: wireless: " or better use something Sedat proposed >> >> -- >> Rafał > > > > Hi > > Nice, yes I miss the Ack :) > > I just got one more complaining about my subject-line in "net: wireless: " > I use some sed call for this, so it's easy to fix. I will now remove that > part hereinafter. > I check in Documentation/ but did not find any clear info for this. > The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
