On 12/24/14 20:04, Jouni Malinen wrote:
On Wed, Dec 24, 2014 at 07:29:04PM +0100, Arend van Spriel wrote:
The firmware on the device *can* have CAC logic built-in. When it
*is* built-in it is however disabled by default. Based on your
feedback I will just detect firmware support, enable dfs in
firmware, and signal DFS offload to hostapd. I would suggest
introducing a new common capability flag for this instead of using a
QCA vendor specific one. That would be odd ;-)
I see nothing odd in other drivers using the already defined QCA vendor
specific nl80211 command. Anyway, I have no issues with a new nl80211
capability flag added for this purpose. You'll probably have better
chances of getting that accepted with an upstream driver using it.
Maybe not odd but counter-intuitive to some people. Anyway, I was
looking at the code in driver_nl80211_capa.c and stumbled upon
WPA_DRIVER_FLAGS_KEY_MGMT_OFFLOAD. I introduced entensible feature flags
upstream just yesterday to accomodate this type of offload. Just curious
but are those QCA vendor specific nl80211 commands used by the upstream
QCA drivers or is this for supporting QCA proprietary drivers. I guess
the latter as that would be the only reason I can think of to have
vendor specific commands.
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
