On 22 December 2014 at 10:05, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: > On 12/21/14 21:14, Rafał Miłecki wrote: >> >> On 21 December 2014 at 20:56, Arend van Spriel<arend@xxxxxxxxxxxx> wrote: >>> >>> On 12/21/14 18:50, Marcel Holtmann wrote: >>>> >>>> >>>> Hi Arend, >>>> >>>>> diff --git a/include/linux/mmc/sdio_ids.h >>>>> b/include/linux/mmc/sdio_ids.h >>>>> index 0f01fe0..61f8318 100644 >>>>> --- a/include/linux/mmc/sdio_ids.h >>>>> +++ b/include/linux/mmc/sdio_ids.h >>>>> @@ -29,6 +29,8 @@ >>>>> #define SDIO_DEVICE_ID_BROADCOM_4329 0x4329 >>>>> #define SDIO_DEVICE_ID_BROADCOM_4330 0x4330 >>>>> #define SDIO_DEVICE_ID_BROADCOM_4334 0x4334 >>>>> +#define SDIO_DEVICE_ID_BROADCOM_43340 43340 >>>>> +#define SDIO_DEVICE_ID_BROADCOM_43341 43341 >>>> >>>> >>>> >>>> the general preference is to have these values in hex. I get the fact >>>> that >>>> they map the marketing number, but that could be just stated in a >>>> comment >>>> after the hex number. >>> >>> >>> Will change that. >> >> >> I vote for keeping user-friendly numbers as comments :) > > > I don't see added value as the define id ends with the marketing number. Ah, right. I was thinking about some less common cases like #define BCMA_CHIP_ID_BCM4707 0x0xCF12 /* 53010 */ but this is not such case obviously. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
