On 17 December 2014 at 11:32, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > >> Assoc peer command contain information about NSS. >> When we will get IEEE80211_RC_NSS_CHANGED we should >> also send (re) assoc peer command to be sure firmware >> will know about it and RC will work correctly. >> >> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> > > Does this fix a user visible bug or is this something you just found > from doing code review? > In case we will get only IEEE80211_RC_NSS_CHANGED we will not update FW configuration correctly. This is not the problem when IBSS, while we update two flags in one step IEEE80211_RC_SUPP_RATES_CHANGED | IEEE80211_RC_NSS_CHANGED. We could have problems when mac80211 will send only NSS_CHANGED flag. This seems could happen when we will get WLAN_EID_OPMODE_NOTIF. I didn't test such case, but I believe some AP could send such notification. So, this fix potential TP issue. BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
