Search Linux Wireless

Re: [PATCH] mac80211: fix deadlocks in debugfs_netdev.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-04-01 at 14:02 +0200, Johannes Berg wrote:
> On Mon, 2008-03-31 at 15:10 -0700, Luis Carlos Cobo wrote:
> > The bug shows up with CONFIG_PREEMPT enabled. Pointed out by Andrew Morton.
> 
> > @@ -51,13 +53,13 @@ static ssize_t ieee80211_if_write(
> >  
> >  	memset(buf, 0x00, sizeof(buf));
> >  	buf_size = min(count, (sizeof(buf)-1));
> > -	read_lock(&dev_base_lock);
> >  	if (copy_from_user(buf, userbuf, buf_size))
> 
> Do we actually still need all this ieee80211_if_write code? It seems
> that nl80211 can fully replace it now.

Yes we do. We cannot tune mesh parameters (Mesh TTL, auto open peer
links, retries, timeouts, and other dozen parameters) through nl80211. 

As the values for those parameters are not yet defined, these knobs are
very useful for performance analysis.

-- 
Luis Carlos Cobo Rus       GnuPG ID: 44019B60
cozybit Inc.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux