Thanks for review, Joe. I will send v2 with -DDEBUG removed. Thanks, Avinash ________________________________________ From: linux-wireless-owner@xxxxxxxxxxxxxxx [linux-wireless-owner@xxxxxxxxxxxxxxx] On Behalf Of Joe Perches [joe@xxxxxxxxxxx] Sent: Wednesday, December 17, 2014 3:11 PM To: Avinash Patil Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo; Marc Yang Subject: Re: [PATCH 1/4] mwifiex: enable -D__CHECK_ENDIAN__ for sparse by default On Wed, 2014-12-17 at 17:24 +0530, Avinash Patil wrote: > Enable the endian checks by default. [] > diff --git a/drivers/net/wireless/mwifiex/Makefile b/drivers/net/wireless/mwifiex/Makefile [] > @@ -53,3 +53,5 @@ obj-$(CONFIG_MWIFIEX_PCIE) += mwifiex_pcie.o > > mwifiex_usb-y += usb.o > obj-$(CONFIG_MWIFIEX_USB) += mwifiex_usb.o > + > +ccflags-y += -D__CHECK_ENDIAN__ -DDEBUG I think the -DDEBUG should not be there. This also forces all the dev_dbg / wiphy_dbg statement to always be emitted. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
