> On Fri, 2014-12-12 at 15:16 +0100, Lorenzo Bianconi wrote: > >> In multi-vif scenario, TPC could be enabled just on given interfaces, >> but driver TPC registers should be configured anyway (so I used a glob >> flag). However I can move that logic in driver code, what do you >> suggest? > > It seems strange that a driver would look at both bss_conf and hw conf > for the same thing - so seems it might be more understandable if it was > in the driver? > In pending driver (ath9k) patches TPC related info in hw conf and bss_conf are not used for the same purpose. The first one is used to configure HW TPC registers, since TPC should be enabled in hw if there is at least one interface where TPC has been configured, whereas the latter it use to figure out if the transmitted frame belongs to a vif where TPC has been previously enabled. If I do not set TPC info in hw conf I have to loop over all vif every time TPC configuration is applied from mac80211, since ath9k uses just hw conf structure to set TX power info. Maybe that solution is a little bit tricky. What do you think? Sorry if in previous emails I was not so clear :) > johannes > Regards, Lorenzo -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
