On 10 December 2014 at 13:31, Michal Kazior <michal.kazior@xxxxxxxxx> wrote:
[...]
> @@ -3036,14 +3061,11 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
> goto err_peer_delete;
> }
>
> - param = WMI_STA_PS_PARAM_TX_WAKE_THRESHOLD;
> - value = WMI_STA_PS_TX_WAKE_THRESHOLD_ALWAYS;
> - ret = ath10k_wmi_set_sta_ps_param(ar, arvif->vdev_id,
> - param, value);
> + ret = ath10k_mac_vif_recalc_ps_wake_threshold(arvif);
> if (ret) {
> - ath10k_warn(ar, "failed to set vdev %i TX wake thresh: %d\n",
> + ath10k_warn(ar, "failed to recalc ps wake threshold on vdev %i: %d\n",
> arvif->vdev_id, ret);
> - goto err_peer_delete;
> + return ret;
Oops. This is wrong. I should keep the goto.
There are also some Rx performance issues related to excessive PS-Poll usage.
I'll re-spin later.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
