On 1 December 2014 at 15:44, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: [...] > int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode) > @@ -1046,7 +1047,12 @@ static int ath10k_core_probe_fw(struct ath10k *ar) > return ret; > } > > - ath10k_core_init_max_sta_count(ar); > + ret = ath10k_core_init_firmware_features(ar); > + if (ret) { > + ath10k_err(ar, "fatal problem with firmware features: %d\n", > + ret); > + return ret; I think you should call ath10k_core_free_firmware_files() and ath10k_hif_power_down() before returning (similar to how ath10k_core_start() failure is handled). Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html