Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 25 November 2014 at 10:04, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: > [...] >>> @@ -1394,12 +1396,19 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar, >>> return false; >>> } >>> >>> + is_mgmt = !!(rxd->attention.flags & >>> + __cpu_to_le32(RX_ATTENTION_FLAGS_MGMT_TYPE)); >>> + has_fcs_err = !!(rxd->attention.flags & >>> + __cpu_to_le32(RX_ATTENTION_FLAGS_FCS_ERR)); >> >> I think I asked this before in some other patch, but isn't '!!' operator >> useless here? is_mgmt is a boolean so the compiler should convert it >> correctly without '!!' anyway, right? > > If I remove `!!` I get: > > warning: incorrect type in assignment (different base types) > expected bool [unsigned] [usertype] is_mgmt > got restricted __le32 Oh. Sorry, my bad. > I could do a temporary `u32 attention` to get rid of the `!!`. You > want me to update it? Please don't, this is fine. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
