On 25 November 2014 at 09:39, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
> Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes:
>
>> +static ssize_t ath10k_reg_value_read(struct file *file,
>> + char __user *user_buf,
>> + size_t count, loff_t *ppos)
>> +{
>> + struct ath10k *ar = file->private_data;
>> + u8 buf[48];
>> + unsigned int len;
>> + u32 reg_addr, reg_val;
>> +
>> + spin_lock_bh(&ar->data_lock);
>> + reg_addr = ar->debug.reg_addr;
>> + spin_unlock_bh(&ar->data_lock);
>> +
>> + reg_val = ath10k_hif_read32(ar, reg_addr);
>> + len = scnprintf(buf, sizeof(buf), "0x%08x:0x%08x\n", reg_addr, reg_val);
>> +
>> + return simple_read_from_buffer(user_buf, count, ppos, buf, len);
>> +}
>
> I just realised that we need to check ar->state to make sure that
> firmware is running. Because of that I'll need to change the data_lock
> to conf_mutex as well.
Hmm.. It could actually work without firmware running. It just reads MMIO.
The problem I see now is the target may not be awake (Bartosz recently
fixed suspend bug by moving ath10k_pci_wake/sleep back to
hif_power_up) and accessing target registers without it being fully
awake can lead to host memory corruption. I guess ar->state will do
for now because getting this to work otherwise is going to be a little
tricky.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
