Sujith Manoharan <sujith@xxxxxxxxxxx> writes: > Kalle Valo wrote: >> No magic numbers, please. I didn't find anything for IV internals from >> ieee80211.h, not sure if we should add them there or just use ath10k >> internal defines. > > We are just retrieving the keyidx from the IV - not sure adding a couple > of macros for "6" and "3" will make any difference. It won't make a difference for you but it will for someone else reading that part of code. keyidx = skb->data[hdrlen + WEP_HDR_IV_LEN] >> WEP_HDR_KEY_ID_LSB; versus: keyidx = skb->data[hdrlen + 3] >> 6; (I didn't check the standard so tha names can be totally wrong.) -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
