Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
> On 11/22/2014 07:28 AM, Kalle Valo wrote:
>> greearb@xxxxxxxxxxxxxxx writes:
>>
>>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>>
>>> There are not many of these messages producted by the
>>> firmware, but they are generally fairly useful, so print
>>> them at info level.
>>>
>>> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>
>> [...]
>>
>>> --- a/drivers/net/wireless/ath/ath10k/debug.h
>>> +++ b/drivers/net/wireless/ath/ath10k/debug.h
>>> @@ -35,6 +35,7 @@ enum ath10k_debug_mask {
>>> ATH10K_DBG_BMI = 0x00000400,
>>> ATH10K_DBG_REGULATORY = 0x00000800,
>>> ATH10K_DBG_TESTMODE = 0x00001000,
>>> + ATH10K_DBG_FW_MSG = 0x00002000,
>>
>> I think FW_MSG is a bit too ambiguous, so I changed this to WMI_PRINT so
>> that it's closer the real event name.
>
> Better than nothing, but my idea was that this flag would be able to affect
> more than one thing related to firmware debugging. Calling it something about
> WMI does not indicate to me that it is really about firmware debugging.
For other debug methods we can always add a new debug level, or rename
this one.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
