On 21 November 2014 10:54, Sujith Manoharan <sujith@xxxxxxxxxxx> wrote: > Michal Kazior wrote: [...] >> Read access to peer->keys should be protected by either data_lock or >> conf_mutex. Obviously the latter can't be used because this function >> will be called from an atomic context leaving the data_lock. The >> entire is_peer_wep_key_set() should require data_lock to be held while >> it is called to avoid races. >> >> Oh, and apparently this is buggy anyway because >> ath10k_install_peer_wep_keys() is oblivious to this. Oops.. > > I don't think it can happen, though ? ath10k_install_peer_wep_keys() > would be called only when a station transitions to ASSOC and message 3 > can't be received when that happens ? Good point, but what I'm worried it'll be easier to miss this subtlety and introduce races in the future. > (But, I did see a lockdep splat when using WEP). Do you have it saved somewhere? If so, can you post it, please? Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
