Search Linux Wireless

Re: [PATCH v6] nl80211: Stop scheduled scan if netlink client disappears

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-11-20 at 13:32 +0200, Jukka Rissanen wrote:

> - moved owner netlink port id from cfg80211_sched_scan_request to
>   rdev in order to avoid possible races

How does that really help though? You're not really locking it anyway.

I think you should consider keeping it inside the sched_scan_request,
but maybe make that an __rcu pointer.

Your patch also still has the problem I pointed out to you before - you
can get the following sequence of events:

start_sched_scan (owner=true)
close socket - schedule worker
start_sched_scan (from another socket, owner doesn't matter)
run worker - cancels the new sched_scan

You need to make sure the worker is flushed in start_sched_scan or so,
which might require RTNL work there or something.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux