Search Linux Wireless

Re: [PATCH v2 2/2] mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-11-12 at 16:42 +0200, Patrik Flykt wrote:

> -	if (param->reg_alpha2)
> +	if (param->reg_alpha2) {
> +		data->alpha2[0] = param->reg_alpha2[0];
> +		data->alpha2[1] = param->reg_alpha2[1];
>  		regulatory_hint(hw->wiphy, param->reg_alpha2);
> +	}


> +	param.reg_alpha2 = data->alpha2;

This seems incorrect, first reg_alpha2 was conditional, and then you
memcpy it, and then you use it unconditionally which may end up as \x00
\x00?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux