On Wed, Nov 19, 2014 at 1:41 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2014-11-19 at 13:40 +0200, Arik Nemtsov wrote: >> On Wed, Nov 19, 2014 at 1:22 PM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Sun, 2014-11-09 at 18:50 +0200, Arik Nemtsov wrote: >> > >> >> + if (WARN_ON(tid >= IEEE80211_NUM_TIDS)) >> >> + return -EINVAL; >> > >> > That validates < 16 >> > >> >> + queues = BIT(sdata->vif.hw_queue[ieee802_1d_to_ac[tid]]); >> > >> > but that's only valid for < 8, causing a smatch warning. >> >> It's a valid warning. It should be tid & 7 here. I'll send a fix. > > yes, but I think &7 is wrong too - TIDs (really TSIDs) 8-15 don't have a > static AC mapping, and we don't support them anyway. I think the sanity > check should just make sure it's < 8. yea you're right. was just writing this :) Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
