On 17 November 2014 15:32, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Michal Kazior <michal.kazior@xxxxxxxxx> writes: > >> This creates a single, common path for MSDU, >> A-MSDU and fragmented Rx. >> >> Hopefully this will make it easier to understand >> Rx path and make it easier to work with. >> >> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> > > This patch had few checkpatch warnings. I fixed them with the folded > patch and full patch here: > > https://github.com/kvalo/ath/commit/71fbd07d43e54f5f9f442bc5f2f4f9ef83aead63 Thanks! [...] > @@ -1132,7 +1133,7 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar, > bool has_fcs_err; > bool has_crypto_err; > bool has_tkip_err; > - bool has_peer_idx_invalid; > + bool has_idx_invalid; > bool is_decrypted; I don't really like the has_idx_invalid. Perhaps has_peer_err conveys a bit more of the original meaning? As much as I'd like to leave the original var name I'd like to be checkpatch warning free. Sigh.. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html