Search Linux Wireless

Re: [PATCH] rt2x00: do not align payload on modern H/W

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 02, 2014 at 01:38:47PM +0100, Stanislaw Gruszka wrote:
> RT2800 and newer hardware require padding between header and payload if
> header length is not multiple of 4.
> 
> For historical reasons we also align payload to to 4 bytes boundary, but
> such alignment is not needed on modern H/W.
> 
> Patch improve performance on embedded CPUs and _possibly_ fixes
> skb_under_panic problems reported from time to time:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=84911
> https://bugzilla.kernel.org/show_bug.cgi?id=72471
> http://marc.info/?l=linux-wireless&m=139108549530402&w=2
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1087591
> 
> But we can not explain or otherwise confirm the patch fixes this panic
> issue for sure.

Antti on https://bugzilla.kernel.org/show_bug.cgi?id=72471 tested patch
and confirm it fixes the panic, he also provided traces showing that we
really eat headroom on each retransmission in some special case - no
payload and header length not being multiple of 4.

Taking that and since this patch was not yet applied I'll repost it with
updated changelog and direct to 3.18 stream and -stable.

Stanislaw

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux