On Sat, 23 Feb 2008 15:17:16 +0100 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > This patch contains the debugfs code for mesh statistics and configuration > parameters. Please note that generic support for r/w debugfs attributes has been > added. y'know, we have carefully developed all this lovely runtime self-checking code in the kernel which can catch all sorts of common errors and yet it's a continual struggle to get kernel developers *of all people* to actually TURN THE DAMN THINGS ON. So. I would ask everyone who "tested" this patch to - read Documentation/SubmitChecklist - suitable modify your .config - SAVE A COPY OF THE THING!!!!! - then fix the obvious, trivial, instantly-detectable, very-deadlockable bug in this patch. There is just no longer any excuse for this: + read_lock(&dev_base_lock); + if (copy_from_user(buf, userbuf, buf_size)) Thanks. There's also a question regarding review quality - I spotted that bug the instant I looked at the patch. It's not exactly subtle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
