On Tue, Nov 04, 2014 at 01:34:37AM +0200, Kalle Valo wrote: > Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes: > > > For packet log, the transmitted frame 802.11 header alone is sufficient. > > Recording entire packet is also consuming lot of disk space. To optimize > > this, tx and rx data tracepoints are splitted into header and payload > > tracepoints. > > > > -DECLARE_EVENT_CLASS(ath10k_data_event, > > +#define ATH10K_FRM_HDR_LEN \ > > + ieee80211_hdrlen(((struct ieee80211_hdr *)data)->frame_control) > > This macro does not look good. I would recommend to follow what Johannes > suggested: > > "It would be worth hiding that inside the tracepoint's assign function, > so instead of passing data/len here you'd pass the full skb, or the full > skb data/skb len, like this: > > ar, skb->data, skb->len > > to both tracers. Then inside the tracer you can do the hdrlen check, and > that way move the code into the tracing so it's not hit when tracing is > disabled." v2 does the same. tracing functions just take ar, skb->data and skb->len. header check is handled inside tracing funtions. I do not understand your concerns. :( -Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
