On Wed, Oct 29, 2014 at 09:13:24AM -0700, Joe Perches wrote: > On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote: > > On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: > > > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > > > > The right shift operation has higher precedence than the mask so we > > > > left shift by "(i * 3)" and then immediately right shift by "(i * 3)" > > > > then we mask. It should be left shift, mask, and then right shift. > [] > > > My grep pattern doesn't like operations on the thing masked. > > > Did you find this by some tool or visual inspection via grep? > [] > > I wrote a Smatch check inspired by the i40e bug you found earlier. > > Nice. fyi: I sent a bunch of these already. > > https://lkml.org/lkml/2014/10/27/38 > Ah... Your grep found a bunch of stuff that I missed because it wasn't in my allmodconfig. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
