On 23 October 2014 15:14, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Michal Kazior <michal.kazior@xxxxxxxxx> writes: > >> On 20 October 2014 14:14, Michal Kazior <michal.kazior@xxxxxxxxx> wrote: >>> One of the problems with warm reset I've found is >>> that it must be guaranteed that copy engine >>> registers are not being accessed while being >>> reset. Otherwise in worst case scenario the host >>> may lock up. >>> >>> Instead of using sleeps and hoping the device is >>> operational in some arbitrary timeframes use >>> firmware indication register. >>> >>> As a side effect this makes driver >>> boot/stop/recovery faster. >>> >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >>> --- >>> >>> Notes: >>> v2: >>> * fix kernel panic on early fw crash due to CE not being fully initialized [Janusz] >> >> Marek reported he sees a memory leak and git bisect blames this patch. >> Please don't apply this patch yet. > > Ok, thanks for letting me know. What about rest of the patches in the > patchset? I assume it's safe to apply them. It's safe to apply: ath10k: re-disable interrupts after target init ath10k: mask/unmask msi fw irq ath10k: split ce pipe init/alloc further Please, do not apply the following yet: ath10k: make warm reset a bit safer and faster (this patch) ath10k: split reset logic from power up ath10k: don't reset chip on power_down Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
