On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: > From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx> > > Hi, > > Varka Bhadram reported checkpatch is noisy on this series. > I made another pass which affects [2/4](trivially) and [4/4]. > This could have been a patch on top of what Felix acked, I hope you > won't bother too much. This series introduces the following new sparse/smatch complaints: CHECK /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht.c /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht.c:246:18: warning: cast to restricted __le16 /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht.c:1227:49: warning: incorrect type in argument 3 (different base types) /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht.c:1227:49: expected unsigned short [unsigned] [usertype] mcs_map /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht.c:1227:49: got restricted __le16 [usertype] tx_mcs_map Here it looks like the argument to minstrel_get_valid_vht_rates() should be declared __le16. CHECK /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c:47 minstrel_ht_stats_dump() error: testing array offset 'i' after use. /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c:61 minstrel_ht_stats_dump() error: testing array offset 'i' after use. Here I'm not sure, seems like it's a false positive maybe? The array seems large enough for everything that's going on here. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
