Search Linux Wireless

Re: [PATCH] cfg80211: Warn once for delayed scan completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-10-20 at 15:57 +0530, Sujith Manoharan wrote:
> Johannes Berg wrote:
> > But the driver can/should just do it when the interface is removed from
> > it? Otherwise it has no valid way to run/continue the scan anyway?
> 
> cancel_hw_scan() is called before remove_interface() and if the
> interface is removed in cfg80211 before __cfg80211_scan_done() gets
> a chance to run, then this warning is hit.

I'm not sure that's true - the WARN_ON you're modifying keys off
something that happens in cfg80211_scan_done(), not
__cfg80211_scan_done(), so as long as the driver called
cfg80211_scan_done() properly things should be OK?

How are you implementing cancel_hw_scan()? You need to call
ieee80211_scan_completed() by the time the function returns.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux