Search Linux Wireless

Re: [PATCH v4 0/4] add VHT support to minstrel_ht

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Varka Bhadram,

On Mon, Oct 20, 2014 at 02:31:31PM +0530, Varka Bhadram wrote:
> Hi Karl Beldan,
> 
> On 10/20/2014 02:25 PM, Karl Beldan wrote:
> >From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx>
> >
> >Hi,
> >
> >This is just a respin rebased on v2 of "mac80211: minstrels: fix buffer
> >overflow in HT debugfs" which only affects 4/4.
> >
> >Karl Beldan (4):
> >   mac80211: minstrel_ht: Increase the range of handled rate indexes
> >   mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs
> >   mac80211: minstrel_ht: include type (cck/ht) in rates flag
> >   mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz
> >v2:
> >- typo in Kconfig
> >- adjust room in debugfs rc_stats buffer
> >- add a module param to mix ht rates with vht ones
> >- default to 3SS instead of 2SS (with "mac80211: minstrel_ht: macros
> >   adjustments for future VHT_GROUPs")
> >- use common MINSTREL_MAX_STREAMS both for VHT and HT so that we can get
> >   rid of the 'MINSTREL_MAX_STREAMS >= 3' checks for minstrel_mcs_groups
> >v3:
> >- put module param *vht_only* under CONFIG_MAC80211_RC_MINSTREL_VHT
> >v4:
> >- rebase on v2 of "mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats"
> >
> >  net/mac80211/Kconfig                       |   7 +
> >  net/mac80211/rc80211_minstrel_ht.c         | 292 +++++++++++++++++++++++------
> >  net/mac80211/rc80211_minstrel_ht.h         |  38 +++-
> >  net/mac80211/rc80211_minstrel_ht_debugfs.c |  32 ++--
> >  4 files changed, 290 insertions(+), 79 deletions(-)
> >
> Check patch errors on this series.. run checkpatch.pl on this series.
> 
Same report as previous series.

Except format warnings there are 2
"ERROR: Macros with complex values should be enclosed in parenthesis",
which fit with current style.

However I too think this series can be improved wrt checkpatch report
and I'll send another version, thanks for pointing that out.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux