Search Linux Wireless

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

If that's not too late I'd like to fix some coding style, replace:

On Fri, Oct 17, 2014 at 08:34:00PM +0200, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx>
> @@ -102,6 +102,8 @@ minstrel_stats_open(struct inode *inode, struct file *file)
>  			mi->sample_packets);
>  	ms->len = p - ms->buf;
>  
> +	WARN_ON(ms->len > 2048 - sizeof(*ms));

with:
	WARN_ON(ms->len + sizeof(*ms) > 2048);
and,

> @@ -118,6 +119,8 @@ minstrel_ht_stats_open(struct inode *inode, struct file *file)
>  		MINSTREL_TRUNC(mi->avg_ampdu_len * 10) % 10);
>  	ms->len = p - ms->buf;
>  
> +	WARN_ON(ms->len > 8192 - sizeof(*ms));

with:
	WARN_ON(ms->len + sizeof(*ms) > 8192);

This would require rebasing "[PATCH v3 4/4] mac80211: minstrel_ht: add
basic support for VHT rates <= 3SS@80MHz", and send 

[PATCH v2] mac80211: minstrels: fix buffer overflow in HT debugfs
[PATCH v4 1/4] mac80211: minstrel_ht: Increase the range of handled
[PATCH v4 2/4] mac80211: minstrel_ht: macros adjustments for future
[PATCH v4 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates
[PATCH v4 4/4] mac80211: minstrel_ht: add basic support for VHT rates

Is it ok ?
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux