> On 14 October 2014 at 20:08 Bjørn Mork <bjorn@xxxxxxx> wrote: > > > Joe Perches <joe@xxxxxxxxxxx> writes: > > > And does this really need to be alloc'd? > > Yes, it does. It is used as a transfer_buffer in usb_fill_bulk_urb() and > must be "suitable for DMA". From include/linux/usb.h: > > /** > * struct urb - USB Request Block > .. > * @transfer_buffer: This identifies the buffer to (or from) which the I/O > * request will be performed unless URB_NO_TRANSFER_DMA_MAP is set > * (however, do not leave garbage in transfer_buffer even then). > * This buffer must be suitable for DMA; allocate it with > * kmalloc() or equivalent. For transfers to "in" endpoints, contents > * of this buffer will be modified. This buffer is used for the data > * stage of control transfers. > > Adding a structure would be a nice design update indeed but this would require some testing...Separate patch maybe ? Fabian > > Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
