Search Linux Wireless

Re: [PATCH] rtl8732au: Fix coding style violations in ieee80211.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2014-10-11 at 12:19 +0800, Matthew Tyler wrote:
> Signed-off-by: Matthew Tyler <matt.tyler@xxxxxxxxxxxx>
[]
> diff --git a/drivers/staging/rtl8723au/include/ieee80211.h b/drivers/staging/rtl8723au/include/ieee80211.h
[]
> -#define IsSupported24G(NetType) (NetType & SUPPORTED_24G_NETTYPE_MSK ? true : false)
> -#define IsSupported5G(NetType) (NetType & SUPPORTED_5G_NETTYPE_MSK ? true : false)
> +#define IsSupported24G(NetType) \
> +	(NetType & SUPPORTED_24G_NETTYPE_MSK ? true : false)

A lot of these would be better as static inlines or
maybe using !! instead of ternaries.

But it doesn't seem any of these IsSupported<foo> macros
are used at all, so probably deleting is best.

> @@ -266,7 +277,9 @@ join_res:
>  */
>  
>  #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
> -#define MAC_ARG(x) ((u8*)(x))[0],((u8*)(x))[1],((u8*)(x))[2],((u8*)(x))[3],((u8*)(x))[4],((u8*)(x))[5]
> +#define MAC_ARG(x) \
> +	(((u8 *)(x))[0], ((u8 *)(x))[1], ((u8 *)(x))[2], \
> +	 ((u8 *)(x))[3], ((u8 *)(x))[4], ((u8 *)(x))[5])

It'd be better to convert these to use %pM


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux