On Thu, Oct 09, 2014 at 03:26:02PM +0200, Johannes Berg wrote: > On Thu, 2014-10-09 at 15:00 +0200, Karl Beldan wrote: > > On Thu, Oct 09, 2014 at 11:32:57AM +0200, Johannes Berg wrote: > > > On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote: > > > > From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx> > > > > > > > > ATM, specifying the frequency when connecting sends a void 'supported > > > > rates' EID. > > > > > > Seems like this should be a stable fix? > > > > > Indeed, I forgot to Cc stable. > > Ok, I guess I can just add it. > > Then again, maybe you can make a bit more verbose commit log, and check > what broke it? > After a glimpse before leaving FWIU : - 6829c878 Jul 2009 - "cfg80211: emulate connect with auth/assoc" original code for 'cmd' ieee80211_build_preq_ies takes supported rates from sband->bitrates[]. - 8dcb2003 Aug 2010 - "mac80211: Filter ProbeReq SuppRates based on TX rate mask" ieee80211_build_preq_ies takes a rate mask, hw_scan uses -1/sw_scan uses sdata->rc_rateidx_mask. - 34850ab2 Jul 2011 - "cfg80211: allow userspace to control supported rates in scan" add a "bitmap of rates to advertise" in the scan request. - 85a237fe Jul 2011 - "mac80211: implement scan supported rates" take the rate mask from 'cmd' - 3965ac00 Sep 2011 - "wireless: Fix rate mask for scan request" fix rate mask when 'cmd' has params.channel .. and rate mask remains unset when 'cmd' has params.channel So I guess it started showing after 85a237fe, but the original cmd never filled a rate mask which started existing only after 34850ab .. Karl -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
