On 8 October 2014 13:13, Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> wrote: > On Wed, Oct 08, 2014 at 04:38:44PM +0530, Rajkumar Manoharan wrote: >> On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote: >> > If anything the offender should be dma_unmap_single() but the thing is >> > beacon_buf is always allocated for AP/IBSS now which means >> > dma_unmap_single() is never called. For non-AP/IBSS both arvif->beacon >> > and arvif->beacon_buf are always NULL so neither >> > dma_alloc/free_coherent nor dma_map/unmap_single are called. >> > >> Agree. We need one more check in ath10k_mac_vif_beacon_free. > > No additional check is needed. For non beaconing mode, arvif->beacon > should be false. isn't it? Correct. No extra checks are necessary. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
