On Fri, 2014-09-26 at 16:24 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> +/*
> + * Attempt to rename a device. Acquire RTNL before calling.
> + */
please add kernel-doc
> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname);
Should also be const char *
And should probably be called cfg80211_rename_wiphy() only? What's the
dev doing there?
>
> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname)
> +{
> + struct cfg80211_registered_device *rdev;
> +
> + rdev = wiphy_to_rdev(wiphy);
> + return cfg80211_dev_rename(rdev, newname);
You could just inlin ethe wiphy_to_rdev() and get rid of the variable.
Anyhow - if the intent is to do this at creation, why do you do it after
the fact? Couldn't you just specify the name when creating it?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
