On Fri, Oct 03, 2014 at 03:11:01PM +0300, Dan Carpenter wrote:
> Hello Sujith Manoharan,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch e6664dff0608: "ath: Add support for tracing" from Sep 27,
> 2014, leads to the following Smatch complaint:
>
> drivers/net/wireless/ath/main.c:88 ath_printk()
> error: we previously assumed 'common->hw' could be null (see line 82)
>
> drivers/net/wireless/ath/main.c
> 81
> 82 if (common && common->hw && common->hw->wiphy)
Oh. And also common is assumed to be possibly NULL as well.
regards,
dan carpenter
> ^^^^^^^^^^
> Existing code assumes common->hw can be NULL.
>
> 83 printk("%sath: %s: %pV",
> 84 level, wiphy_name(common->hw->wiphy), &vaf);
> 85 else
> 86 printk("%sath: %pV", level, &vaf);
> 87
> 88 trace_ath_log(common->hw->wiphy, &vaf);
> ^^^^^^^^^^^^^^^^^
> New code dereferences it without checking for NULL.
>
> 89
> 90 va_end(args);
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
