Search Linux Wireless

Re: NFC: trf7970a: Handle timeout values of zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 01, 2014 at 05:20:48PM +0300, Dan Carpenter wrote:
> Hello Mark A. Greer,
> 
> The patch 1961843ceeca: "NFC: trf7970a: Handle timeout values of
> zero" from Sep 2, 2014, leads to the following static checker warning:
> 
> 	drivers/nfc/trf7970a.c:897 trf7970a_irq()
> 	warn: passing zero to 'ERR_PTR'
> 
> drivers/nfc/trf7970a.c
>    892                          trf7970a_cmd(trf, TRF7970A_CMD_FIFO_RESET);
>    893  
>    894                          if (!trf->timeout) {
>    895                                  trf->ignore_timeout = !cancel_delayed_work(
>    896                                                  &trf->timeout_work);
>    897                                  trf->rx_skb = ERR_PTR(0);
>                                                       ^^^^^^^^^^
> Why not just say "NULL"?

No reason.  I thought I'd fixed them all.

Mark
--
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux