Sujith Manoharan <sujith@xxxxxxxxxxx> writes: > From: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx> > > Signed-off-by: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx> > --- > drivers/net/wireless/ath/Kconfig | 8 +++++ > drivers/net/wireless/ath/Makefile | 4 +++ > drivers/net/wireless/ath/ath.h | 1 + > drivers/net/wireless/ath/main.c | 3 ++ > drivers/net/wireless/ath/trace.c | 20 +++++++++++ > drivers/net/wireless/ath/trace.h | 71 +++++++++++++++++++++++++++++++++++++++ Why add it to ath.ko module? What drivers are going to use this? Because all ath* drivers are different, I suspect there is not that much to share between drivers and that's why it would be better to have the trace points per driver. And I just checked that currently we have trace points for ath10k, ath5k, ath6kl and wil6210. IMHO adding more trace points to ath.ko just makes this confusing. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html