Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 23 September 2014 16:32, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > [...] >> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c >> index 101c6f9cf2a8..426341480262 100644 >> --- a/drivers/net/wireless/ath/ath10k/debug.c >> +++ b/drivers/net/wireless/ath/ath10k/debug.c > [...] >> +static int ath10k_cal_data_open(struct inode *inode, struct file *file) > > Shouldn't functions in debug.c have ath10k_debug_ prefix? I'm aware > other fops stuff doesn't include the _debug word as well so this is > somewhat consistent with the current code but is this okay in the > grand scheme of things? Just wondering. IMHO we should use ath10k_debug_ with fops functions as well, I just haven't been that picky about that. I'll change this as well and send v3. Thanks for review! -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
