Search Linux Wireless

RE: [PATCH 13/17] iwlwifi: 8000: fix fw name to account for revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> Emmanuel Grumbach <egrumbach@xxxxxxxxx> writes:
> 
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-8000.c
> > b/drivers/net/wireless/iwlwifi/iwl-8000.c
> > index 4ae8ba6..e435148 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-8000.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-8000.c
> > @@ -81,7 +81,7 @@
> >  #define IWL8000_NVM_VERSION		0x0a1d
> >  #define IWL8000_TX_POWER_VERSION	0xffff /* meaningless */
> >
> > -#define IWL8000_FW_PRE "iwlwifi-8000-"
> > +#define IWL8000_FW_PRE "iwlwifi-8000"
> >  #define IWL8000_MODULE_FIRMWARE(api) IWL8000_FW_PRE
> __stringify(api) ".ucode"
> 
> Isn't this going to create a misleading MODULE_FIRMWARE entry, matching
> neither of the firmware variants?
> 
>
Yes probably - OTOH, this device is far from being on the shelves. By the time it will hit the shelves, we will have removed all the hacks for the early steps of the hardware.
Ideas to make it better?

Good to know that someone is actually looking at the patches I take care to send :)
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux