Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> This makes it easier to debug hex dumps on systems
> with more than a single ath10k device.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
[...]
> - print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len);
> + for (ptr = buf; (ptr - buf) < len; ptr += 16) {
> + linebuflen = 0;
> + if (prefix)
> + linebuflen += scnprintf(linebuf + linebuflen,
> + sizeof(linebuf) -
> + linebuflen,
> + "%s", prefix);
> + linebuflen += scnprintf(linebuf + linebuflen,
> + sizeof(linebuf) - linebuflen,
> + "%08x: ",
> + (unsigned int)(ptr - buf));
> + hex_dump_to_buffer(ptr, len - (ptr - buf), 16, 1,
> + linebuf + linebuflen,
> + sizeof(linebuf) - linebuflen, true);
> + dev_printk(KERN_DEBUG, ar->dev, "%s\n", linebuf);
> + }
Would it be possible to simplify this to one scnprintf()? Something
like:
linebuflen += scnprintf(linebuf + linebuflen,
sizeof(linebuf) - linebuflen,
"%s%08x: ",
prefix ? prefix : "",
(unsigned int)(ptr - buf));
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
