>> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
>> index f1db15b..0b2d55d 100644
>> --- a/include/uapi/linux/nl80211.h
>> +++ b/include/uapi/linux/nl80211.h
>> @@ -1594,6 +1594,9 @@ enum nl80211_commands {
>> * @NL80211_ATTR_TDLS_INITIATOR: flag attribute indicating the current end is
>> * the TDLS link initiator.
>> *
>> + * @NL80211_ATTR_WIPHY_DYN_ACK: whether dynamic ack timeout estimation
>> + * algorithm is enabled
>
> You should probably describe that it's related to the
> NL80211_FEATURE_ACKTO_ESTIMATION feature (and you should document that
> it's a flag) since otherwise nobody will be able to correlate the two
> things easily. :)
>
>
>> + if (info->attrs[NL80211_ATTR_WIPHY_DYN_ACK]) {
>> + if (!(rdev->wiphy.features &
>> NL80211_FEATURE_ACKTO_ESTIMATION))
>> + return -EOPNOTSUPP;
>> +
>> + changed |= WIPHY_PARAM_DYN_ACK;
>> + }
>
> that doesn't really seem right, how do you turn it off??
>
dynack is disable by default at bootstrap and it is automatically
disabled as soon as you set coverage_class (coverage_class >= 0) after
dynack has been enabled (coverage_class = -1). E.g:
- iw phy phy0 set distance auto (to enable dynack)
- iw phy phy0 set distance x (to set coverage class and disable dynack)
This logic is implemented in dynack code. Is it fine for you?
Anyway documentation should be clearer on that stuff. :)
> johannes
>
Regards,
Lorenzo
--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
