Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 8 August 2014 12:45, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> >>> The soc powersave was disabled by default. It >>> never was fully tested. Some hw apparently had >>> problems with it and the implementation itself had >>> a possible race. >>> >>> Just remove the refcounting and simply wake up the >>> device when probing and put to sleep when >>> removing. >>> >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> >> This one introduced new warnings: >> >> drivers/net/wireless/ath/ath10k/pci.c:646:5: warning: symbol 'ath10k_pci_wake' was not declared. Should it be static? >> drivers/net/wireless/ath/ath10k/pci.c:653:6: warning: symbol 'ath10k_pci_sleep' was not declared. Should it be static? > > I didn't catch this for some reason. Can you share how you run > checkpatch, please? I think these are coming from sparse, in essence I run this: make drivers/net/wireless/ath/ath10k/ C=2 CF="-D__CHECK_ENDIAN__" Which reminds me that I should add -D__CHECK_ENDIAN__ to the makefile. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
