On 07.08.2014 15:04, Christian Lamparter wrote:
On Thursday, August 07, 2014 01:42:28 PM Ronald Wahl wrote:
What about this:
if (usb_endpoint_num(ep) == AR9170_USB_EP_CMD &&
usb_endpoint_is_bulk_out(ep))
ar->usb_ep_cmd_is_bulk = true;
(the driver context "ar" is zero'd out - It is not necessary to set
usb_ep_cmd_is_bulk to false.)
This is what my first patch has done but we need to check the endpoint
type if its bulk or not. Otherwise it will fail in the high-speed case.
Or did you mean:
if (usb_endpoint_num(ep) == AR9170_USB_EP_CMD &&
usb_endpoint_is_bulk_out(ep) &&
usb_endpoint_type(ep) == USB_ENDPOINT_XFER_BULK)
ar->usb_ep_cmd_is_bulk = true;
usb_endpoint_is_bulk_out [0] "checks if the endpoint is bulk OUT".
This function should perform both checks (ie.: is bulk? is out?).
Oh, I overlooked the _bulk_ in the function name. :-)
Anyway, the v3 patch that I have send out in the meantime did not have
this minor optimization but this shouldn't actually really matter I think.
- ron
--
Ronald Wahl - ronald.wahl@xxxxxxxxxxx - Phone +49 375271349-0 Fax -99
Raritan Deutschland GmbH, Kornmarkt 7, 08056 Zwickau, Germany
USt-IdNr. DE813094160, Steuer-Nr. 227/117/01749
Amtsgericht Chemnitz HRB 23605
Geschäftsführung: Stuart Hopper, Ralf Ploenes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
