Search Linux Wireless

Re: [PATCH 1/5] b43: Use the b43_phy_maskset where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 18 March 2008 01:47:29 Harvey Harrison wrote:
> [lots of patches]

What do these patches actually fix?
I see they shuffle a _lot_ of code around, but what does that
actually fix? As I said, I won't apply any patch that just shuffles
code without fixing anything.

This shuffling has a _HUGE_ risk of introducing bugs that I am NOT
going to debug and fix afterwards.
The code works pretty well. There's absolutely no need to rewrite it.

And no, "this makes the code 200bytes smaller" doesn't count as a fix. :)

We do _not_ understand what this code does and it is a really really huge
pain in the ass to debug. So I am not going to risk bugs here.

Please search for another target, like the b43-MAC code (everything except
the PHY stuff).
Of course, if you found an actual bug in the PHY code, I'd like to know
and I'd like to have a patch that fixes it without shuffling hundreds
of lines of code.

Thanks a lot.

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux