Search Linux Wireless

Re: [PATCHv2 1/2] cfg80211: extend coverage_class datatype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, 2014-07-24 at 12:39 +0200, Lorenzo Bianconi wrote:
>
>> @@ -1269,8 +1270,8 @@ static int nl80211_send_wiphy(struct cfg80211_registered_device *rdev,
>>                               rdev->wiphy.frag_threshold) ||
>>                   nla_put_u32(msg, NL80211_ATTR_WIPHY_RTS_THRESHOLD,
>>                               rdev->wiphy.rts_threshold) ||
>> -                 nla_put_u8(msg, NL80211_ATTR_WIPHY_COVERAGE_CLASS,
>> -                            rdev->wiphy.coverage_class) ||
>> +                 nla_put_s16(msg, NL80211_ATTR_WIPHY_COVERAGE_CLASS,
>> +                             rdev->wiphy.coverage_class) ||
>>                   nla_put_u8(msg, NL80211_ATTR_MAX_NUM_SCAN_SSIDS,
>>                              rdev->wiphy.max_scan_ssids) ||
>>                   nla_put_u8(msg, NL80211_ATTR_MAX_NUM_SCHED_SCAN_SSIDS,
>
> This will break existing userspace.
>
> Also please supply a better commit message.
>
> johannes
>

Ack

-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux