Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> On 24 July 2014 11:29, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx> writes:
>>
>>> Adds the spectral scan feature for ath10k. The spectral scan is triggered by
>>> configuring a mode through a debugfs control file. Samples can be gathered via
>>> another relay debugfs file.
>>>
> [...]
>>> @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
>>> else
>>> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
>>>
>>> - INIT_LIST_HEAD(&ar->arvifs);
>>> -
>>> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
>>> ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
>>> ar->hw_params.name,
>>> @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev,
>>> INIT_WORK(&ar->register_work, ath10k_core_register_work);
>>> INIT_WORK(&ar->restart_work, ath10k_core_restart);
>>>
>>> + INIT_LIST_HEAD(&ar->arvifs);
>>
>> I'm a bit suspicious about this, why is it needed?
>
> Good hunch. ar->arvifs must be re-initialized in core_start for
> recovery to work correctly.
Thanks for the confirmation. I think I found a way to rework the
spectral initialisation which also fixes this issue, I'll send a new
version later today. Need to run some tests first.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
