> > Huh ok. But how would the WEP legacy station be able to determine that? Legacy user get the key written on 'positit' yellow paper :). > Or does it just try to use WEP and succeed? TBH, I was unaware that this > existed, this does make it a bit more of a problem than I thought then. > > > > > On second thought is that AP has only TX group key while STA has only > > RX group key so I > > m not seeing here any need for flag. > > Hm, well, I didn't really want to require the driver to keep track of > the current operating mode, so that's why I used 00:...:00 vs. FF:...:FF > for the group keys. Isn't if on integer faster then comparing 6 bytes? > > Is that really done though? I mean, does wpa_supplicant not also use > encodeext for WEP keys? > Unfortunately yes. > > > /* IW_AUTH_PAIRWISE_CIPHER and IW_AUTH_GROUP_CIPHER values (bit field) */ > > #define IW_AUTH_CIPHER_NONE 0x00000001 > > #define IW_AUTH_CIPHER_WEP40 0x00000002 > > #define IW_AUTH_CIPHER_TKIP 0x00000004 > > #define IW_AUTH_CIPHER_CCMP 0x00000008 > > #define IW_AUTH_CIPHER_WEP104 0x00000010 > > > > It's not well defined in wext but we can at least define the interface > > from mac80211 point of view. > > True. So what change do we need? > First of all we don't need 4 keys per station but for the whole system. Even in AP mode with multiple SSID meaning multiple security setting you cannot distinguish between networks in static WEP key setting so 4 is enough. Beside that you need place holder for group key. They might be multiple groups key in case of multiple SSIDs in AP mode, iwlwifi doesn't support it in HW but in general it is possible. We need a flag in set_key which says whether the WEP key is static or not. Actually second items is currently the show stopper for me the first Item is just a cleanup. Thanks Tomas > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
