Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > On 18 July 2014 14:50, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: >> >>> In case of A-MSDU RX we should check flags for all >>> MSDU subframes to be sure we have correct FCS status. >>> >>> Before we check attention flags only for first frame >>> where we didn't have correct info about FCS status in >>> case of A-MSDU. Next didn't mark RX_FLAG_FAILED_FCS_CRC >>> for skb. As a side efect we see big TP drop when TCP used. >>> This was easy to reproduce when AP interface was used >>> and added monitor interface run in promiscuous mode. >>> >>> Reported-by: Denton Gentry <denton.gentry@xxxxxxxxx> >>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> >> >> I'm having a hard time to understand the commit log. I think it would >> make it easier to read if you first clearly describe the bug you are >> fixing and then, in a separate paragraph, tell how you fix it. > > Will change that. Thanks. What you wrote in this email was really good, I understand the issue now and I'm sure so do others. I think you should put the same in the commit log, there's no max limit for that anyway :) Also add verb "using" to the title: "ath10k: handle attention flags correctly when using A-MSDU" -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
