RE: [PATCH 4/7] mwifiex: remove redundant TDLS setup action frame check

[Bing Zhao <bzhao@xxxxxxxxxxx>]

Hi Paul,

Thanks for your comment.

> > @@ -791,19 +791,15 @@ void mwifiex_process_tdls_action_frame(struct mwifiex_private *priv,
> >                 return;
> >
> >         peer = buf + ETH_ALEN;
> > -       action = *(buf + sizeof(struct ethhdr) + 2);
> >
> > -       /* just handle TDLS setup request/response/confirm */
> > -       if (action > WLAN_TDLS_SETUP_CONFIRM)
> I'm going to assume that the intent of the original test was to avoid
> allocation of sta_ptr below in the case where the action was invalid.
> Is it okay to allocate this pointer and not do anything with it below?

I've sent v2 patch. Could you please review?

Thanks,
Bing

> > +       sta_ptr = mwifiex_add_sta_entry(priv, peer);
> > +       if (!sta_ptr)
> >                 return;
> >
> > +       action = *(buf + sizeof(struct ethhdr) + 2);
> >         dev_dbg(priv->adapter->dev,
> >                 "rx:tdls action: peer=%pM, action=%d\n", peer, action);
> >
> > -       sta_ptr = mwifiex_add_sta_entry(priv, peer);
> > -       if (!sta_ptr)
> > -               return;
> > -
> >         switch (action) {
> >         case WLAN_TDLS_SETUP_REQUEST:
> >                 if (len < (sizeof(struct ethhdr) + TDLS_REQ_FIX_LEN))
> > --
> > 1.8.2.3
> >
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f